Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add Delivery Address field to Purchase Orders#9768

Open
Reza98Sh wants to merge 8 commits into
inventree:masterfrom
Reza98Sh:feature/issue9303
Open

feat: Add Delivery Address field to Purchase Orders#9768
Reza98Sh wants to merge 8 commits into
inventree:masterfrom
Reza98Sh:feature/issue9303

Conversation

@Reza98Sh

@Reza98Sh Reza98Sh commented Jun 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request implements the feature requested in #9303 by adding a dedicated delivery_address field to Purchase Orders.

Changes Implemented

Backend:

  • Created a new database migration (0110_purchaseorder_delivery_address.py) to apply the schema change.
  • Added a delivery_address ForeignKey field to the PurchaseOrder model, linking to company.Address.
  • Exposed the delivery_address field in the PurchaseOrderSerializer to make it available via the API.
  • Included delivery_address in the autocomplete_fields in PurchaseOrderAdmin for a better user experience in the admin panel.

Frontend:

  • Added the delivery_address field to the usePurchaseOrderFields hook, making it visible and editable in the Purchase Order forms.

Closes #9303

@netlify

netlify Bot commented Jun 12, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit eba545e
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/68e10bd30e3e580008bc1539
😎 Deploy Preview https://deploy-preview-9768--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🔴 down 1 from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Reza98Sh

Reza98Sh commented Jun 12, 2025

Copy link
Copy Markdown
Contributor Author

If this method is not considered best practice, please let me know.
I am doing my best to improve it.

@matmair

matmair commented Jun 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@Reza98Sh there is a conflict in the migrations; please delete the ones you added and regenerate them

matmair
matmair requested changes Jun 12, 2025
View reviewed changes

@matmair matmair left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good for a first PR

Comment thread src/backend/InvenTree/order/models.py Outdated
@SchrodingersGat

SchrodingersGat commented Jun 12, 2025

Copy link
Copy Markdown
Member

An implementation question: where / how do the users define an address for "themself" which can be used here?

One approach might be to create a "company" object which is the "internal" company, which can then have one or more addresses associated with it?

Any other ideas?

@Reza98Sh Reza98Sh force-pushed the feature/issue9303 branch from f87e685 to a36d430 Compare June 13, 2025 10:06
@Reza98Sh

Reza98Sh commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

An implementation question: where / how do the users define an address for "themself" which can be used here?

One approach might be to create a "company" object which is the "internal" company, which can then have one or more addresses associated with it?

Any other ideas?

Sorry I haven't any serious experience with InvenTree but I think It's good if there is option to create address without define company

@Reza98Sh Reza98Sh requested a review from matmair June 13, 2025 10:25
@SchrodingersGat

SchrodingersGat commented Jun 13, 2025

Copy link
Copy Markdown
Member

@matmair thoughts on this? Does a set of "internal addresses" for "me" (which are not linked to a company object) make the most sense?

@matmair

matmair commented Jun 13, 2025

Copy link
Copy Markdown
Member

There is no real inherent connection between Addresses and Companies but the way the current data model works there are a few functions that would need rethinking.

Mainly:

  • shipping notes
  • primary addresses

Having (1 or more) internal companies as references would be nice for a few of the open EPICs.
My suggestion for now: creating a special "locked/protected" company that represents the org that owns the InvenTree instance and link the addresses there.

@codecov

codecov Bot commented Jun 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (b465900) to head (3980b67).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9768   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files        1234     1235    +1     
  Lines       54239    54245    +6     
  Branches     2236     2236           
=======================================
+ Hits        46830    46839    +9     
+ Misses       6841     6838    -3     
  Partials      568      568
Flag Coverage Δ
backend 88.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

This PR seems stale. Please react to show this is still important.

@github-actions github-actions Bot added the inactive Indicates lack of activity label Sep 18, 2025
@github-actions github-actions Bot closed this Sep 25, 2025
@matmair

matmair commented Sep 25, 2025

Copy link
Copy Markdown
Member

Still relevant

@matmair matmair reopened this Sep 25, 2025
@github-actions github-actions Bot removed the inactive Indicates lack of activity label Sep 26, 2025
@SchrodingersGat SchrodingersGat added this to the 1.2.0 milestone Nov 1, 2025
@SchrodingersGat

SchrodingersGat commented Nov 1, 2025

Copy link
Copy Markdown
Member

@Reza98Sh I'm moving this to the 1.2.0 release target - there are still some questions to address here, I will get back to review this soon

@SchrodingersGat SchrodingersGat removed this from the 1.2.0 milestone Feb 10, 2026
@SchrodingersGat SchrodingersGat added this to the 1.3.0 milestone Feb 10, 2026
@gunstr

gunstr commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

I have the need to add our own company in the header for Sales Ordrers and found this PR. Would it make sense to make it generic and create an internal company how "owns" the database and expose the same to all reports? I can see the need also for other kind of reports (e.g. stock reports) where it would be beneficial if the report included the company it's valid for in the header.

@SchrodingersGat SchrodingersGat modified the milestones: 1.3.0, 1.4.0 Mar 18, 2026
@SchrodingersGat SchrodingersGat mentioned this pull request May 31, 2026
Open
@SchrodingersGat SchrodingersGat modified the milestones: 1.4.0, 1.5.0 Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matmair matmair matmair approved these changes
@SchrodingersGat SchrodingersGat Awaiting requested review from SchrodingersGat SchrodingersGat is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

[FR] Delivery Address on Purchase Orders

4 participants

@Reza98Sh @matmair @SchrodingersGat @gunstr