Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(segment-view): scroll to correct content when height is not set #30547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2025
Merged

fix(segment-view): scroll to correct content when height is not set #30547

merged 5 commits into from
Jul 16, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jul 14, 2025 •
edited
Loading

Issue number: resolves #30543

What is the current behavior?

On desktop Safari and Android the segment view is not switching to the right segment content when the height is dynamically set or read in as 0. This can be reproduced in the following StackBlitz on Android: https://6dhropnr-aheyyprl.stackblitz.io/

What is the new behavior?

  • Sets min-height to 1px on ion-segment-content so that it continues to work with a dynamically set height
  • Adds an e2e test for Safari to verify the correct content is displayed when it contains a dynamically loaded image

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.6.2-dev.11752524287.1d61cd78

Preview

@vercel Vercel
Copy link

vercel bot commented Jul 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 2:53pm

@github-actions github-actions bot added the package: core @ionic/core package label Jul 14, 2025
@brandyscarney brandyscarney mentioned this pull request Jul 14, 2025
Closed
3 tasks
@brandyscarney brandyscarney marked this pull request as ready for review July 15, 2025 20:12
@brandyscarney brandyscarney requested a review from a team as a code owner July 15, 2025 20:12
@brandyscarney brandyscarney requested a review from ShaneK July 15, 2025 20:12
ShaneK
ShaneK approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified this fix works in Safari and generally approve. However, I do think the test may cause us grief in the future and recommend changing it.

@brandyscarney brandyscarney added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit d14311f Jul 16, 2025
51 checks passed
@brandyscarney brandyscarney deleted the FW-6586 branch July 16, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneK ShaneK ShaneK approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: iOS/Safari: Swipeable second segment view not loading as default despite being selected
2 participants
@brandyscarney @ShaneK