feat(col): modernizing Grid component #30658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BenOsodrac
approved these changes
Aug 28, 2025
This reverts commit 35903c0.
ShaneK
requested changes
Sep 10, 2025
core/src/components/row/row.scss
Outdated
| display: flex; | ||
|
|
||
| flex-wrap: wrap; | ||
|
|
||
| gap: var(--ion-grid-gap, 0px); |
There was a problem hiding this comment.
This will always be 0px, I believe, since you're setting this var and using it in the same block. Is this intended? Seems redundant.
There was a problem hiding this comment.
The way you resolved this is sort of the opposite of what I expected. I think you should leave the default and remove the --ion-grid-gap definition. Defining it in this block means it has to be overwritten here (specifically, on each row individually) and can't be inherited from anywhere else in the app, which sorta subverts the cascading part of cascading style sheets. I think you should remove the initial definition and leave the 0px fallback.
Co-authored-by: Shane <[email protected]>
Co-authored-by: Shane <[email protected]>
Co-authored-by: Shane <[email protected]>
Co-authored-by: Shane <[email protected]>
This reverts commit 1b707c0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The existing grid component (
ion-grid,ion-row, andion-col) in Ionic was developed several years ago and has not received significant updates since then. As a result, it does not leverage modern CSS features. For example, the gutter (spacing) between columns is implemented using the border property, which is an outdated technique.What is the new behavior?
--ion-grid-gap: this new CSS variable, will indicate the gap size in the grid. Defaults to0px- the current value.ion-col: has a new way to calculate the width of the column. Additionally a new propertyorder(and responsive variants) was added, and will control the order of the column.ion-row: uses the newly introduced custom property--ion-grid-gap. This property will indicate the gap size in the grid.Does this introduce a breaking change?
The properties
pullandpushfromion-col, have been removed. The functionality achieved with them, is now achieved with the new propertyorderand the existingsize. More information and migration examples can be read inBREAKING.mdfile.Other information