Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 22, 2022. It is now read-only.

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Apr 21, 2020

Changes to dir-index.html only (see question below):

  • Adds links and bug report icon requested in Add IPFS links to the header #1
  • Updates header color and adds header border
  • Updates IPFS logo
  • Misc minor visual styling

Note that this still isn't responsive; fixing that is more involved and is part of #24.

Question: What's the situation with dir-index.html vs dir-index-uncat.html? Are we maintaining both of these? If so, would still appreciate a review before duplicating changes to dir-index-uncat.html.

Closes #1

@jessicaschilling
Copy link
Contributor Author

@Stebalien -- do you mind having a look if you have time? Thanks!

@Stebalien
Copy link
Member

Question: What's the situation with dir-index.html vs dir-index-uncat.html? Are we maintaining both of these? If so, would still appreciate a review before duplicating changes to dir-index-uncat.html.

We're trying to, at least. We should add a script that generate dir-index.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with go-ipfs and it looks good to me!

@jessicaschilling
Copy link
Contributor Author

@Stebalien - thanks! Just duplicated the dir-index.html changes to dir-index-uncat.html. Should be good to go.

@Stebalien Stebalien merged commit 545a1fd into master Apr 21, 2020
@lidel
Copy link
Member

lidel commented Apr 22, 2020

@jessicaschilling just tested this with go-ipfs 0.5.50-rc3 and looks awesome! ❤️

Mind updating screenshot in README.md?
I would do it myself but screenshots made on Linux are fugly 😓

@jessicaschilling jessicaschilling deleted the issue-1 branch April 22, 2020 22:46
@jessicaschilling
Copy link
Contributor Author

@lidel Yours to merge: #28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IPFS links to the header
3 participants