Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: cancel stream reader on request abort #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix: cancel stream reader on request abort #158

merged 2 commits into from
Jul 9, 2024

Conversation

achingbrain
Copy link
Member

We need to cancel the reader on request abort, otherwise we leak resources.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: cancel stream reader on request abort
226c08b 
We need to cancel the reader on request abort, otherwise we leak
resources.
@achingbrain achingbrain requested a review from SgtPooki April 15, 2024 09:03
@SgtPooki
Copy link
Member

I wanted to make sure we were catching stream failures before approving #154. I think this one does it.

@SgtPooki SgtPooki mentioned this pull request Apr 15, 2024
Merged
3 tasks
@achingbrain achingbrain merged commit 5819965 into main Jul 9, 2024
@achingbrain achingbrain deleted the fix/cancel-reader-on-abort branch July 9, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @SgtPooki