fix: throw if asked to delete a block we don't have #88

achingbrain · 2019-10-04T16:54:02Z

This is to be consistent with go-IPFS

BREAKING CHANGE:

bs.delete(cid) used to ignore mystery CIDs, now it throws.

This is to be consistent with go-IPFS BREAKING CHANGE: `bs.delete(cid)` used to ignore mystery CIDs, now it throws.

vmx

I'm sorry that this one slipped my attention.

fix: throw if asked to delete a block we don't have

cf04857

This is to be consistent with go-IPFS BREAKING CHANGE: `bs.delete(cid)` used to ignore mystery CIDs, now it throws.

achingbrain requested a review from dirkmc October 4, 2019 16:54

alanshaw approved these changes Dec 11, 2019

View reviewed changes

achingbrain requested a review from vmx April 15, 2020 10:04

vmx approved these changes Apr 15, 2020

View reviewed changes

achingbrain added 2 commits April 16, 2020 15:15

Merge branch 'master' into throw-if-asked-to-delete-non-existent-block

d2677c6

fix: fix tests

f2a4636

vmx merged commit 4ffb28c into master Apr 16, 2020

vmx deleted the throw-if-asked-to-delete-non-existent-block branch April 16, 2020 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: throw if asked to delete a block we don't have #88

fix: throw if asked to delete a block we don't have #88

Uh oh!

achingbrain commented Oct 4, 2019

Uh oh!

vmx left a comment

Uh oh!

Uh oh!

fix: throw if asked to delete a block we don't have #88

fix: throw if asked to delete a block we don't have #88

Uh oh!

Conversation

achingbrain commented Oct 4, 2019

Uh oh!

vmx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!