Strict typing for IPython.utils.text

Carreau · Carreau · commit 30d564c55c3d · 2025-11-04T10:26:20.000+01:00
diff --git a/IPython/utils/text.py b/IPython/utils/text.py
@@ -102,7 +102,7 @@ def get_paths(self) -> List[Path]:
 # print_lsstring = result_display.register(LSString)(print_lsstring)
 
 
-class SList(list):
+class SList(list[Any]):
     """List derivative with a special access attributes.
 
     These are normal lists, but with the special attributes:
@@ -518,7 +518,7 @@ def vformat(
 
                 # do any conversion on the resulting object
                 # type issue in typeshed, fined in https://github.com/python/typeshed/pull/11377
-                obj = self.convert_field(obj, conversion)  # type: ignore[arg-type]
+                obj = self.convert_field(obj, conversion)
 
                 # format the object and append to the result
                 result.append(self.format_field(obj, ''))
@@ -550,7 +550,7 @@ class DollarFormatter(FullEvalFormatter):
         r"(.*?)\$(\$?[\w\.]+)(?=([^']*'[^']*')*[^']*$)"
     )
 
-    def parse(self, fmt_string: str) -> Iterator[Tuple[Any, Any, Any, Any]]:  # type: ignore[explicit-override]
+    def parse(self, fmt_string: str) -> Iterator[Tuple[Any, Any, Any, Any]]:
         for literal_txt, field_name, format_spec, conversion in Formatter.parse(
             self, fmt_string
         ):
diff --git a/pyproject.toml b/pyproject.toml
@@ -129,7 +129,6 @@ enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
 [[tool.mypy.overrides]]
 module = [
     "IPython.core.crashhandler",
-    "IPython.utils.text",
 ]
 check_untyped_defs = true
 disallow_incomplete_defs = true
@@ -165,10 +164,15 @@ ignore_missing_imports = false
 [[tool.mypy.overrides]]
 module = [
     "IPython.core.events",
+    "IPython.utils.text",
 ]
+check_untyped_defs = true
+disallow_incomplete_defs = true
+disallow_untyped_calls = true
+disallow_untyped_decorators = true
+disallow_untyped_defs = true
 ignore_errors = false
 ignore_missing_imports = false
-strict = true
 
 [[tool.mypy.overrides]]
 module = [
