revert-subscript-changes

Darshan808 · Darshan808 · commit 5c4437874764 · 2025-10-26T21:41:52.000+05:45
diff --git a/IPython/core/guarded_eval.py b/IPython/core/guarded_eval.py
@@ -608,34 +608,6 @@ def _handle_assign(node: ast.Assign, context: EvaluationContext):
                         transient_locals[targets[i].id] = values[
                             len(values) - (len(targets) - i)
                         ]
-        elif isinstance(target, ast.Subscript):
-            if isinstance(target.value, ast.Name):
-                name = target.value.id
-                container = transient_locals.get(name)
-                if container is None:
-                    container = context.locals.get(name)
-                if container is None:
-                    container = context.globals.get(name)
-                if container is None:
-                    raise NameError(
-                        f"{name} not found in locals, globals, nor builtins"
-                    )
-
-                key = eval_node(target.slice, context)
-                if policy.can_call(container.__setitem__):
-                    container[key] = value
-
-            elif isinstance(
-                target.value, ast.Attribute
-            ) and _is_instance_attribute_assignment(target.value, context):
-                attr = target.value.attr
-                container = class_transients.get(attr, None)
-                if container is None:
-                    raise NameError(f"{attr} not found in class transients")
-
-                key = eval_node(target.slice, context)
-                if policy.can_call(container.__setitem__):
-                    container[key] = value
         elif _is_instance_attribute_assignment(target, context):
             class_transients[target.attr] = value
         else:
@@ -1320,7 +1292,6 @@ def _list_methods(cls, source=None):
     collections.Counter.most_common,
     object.__dir__,
     type.__dir__,
-    dict.__setitem__,
 }
 
 BUILTIN_GETATTR: set[MayHaveGetattr] = {
diff --git a/tests/test_completer.py b/tests/test_completer.py
@@ -2240,18 +2240,6 @@ def _(expected):
             ),
             "append",
         ],
-        [
-            "\n".join(
-                [
-                    "def test():",
-                    "   a = {}",
-                    "   a['b'] = []",
-                    "   return a",
-                    "test()['b'].",
-                ]
-            ),
-            "append",
-        ],
         [
             "\n".join(
                 [
