disable specifying kernel args on the notebook command-line #5593
Conversation
|
We only gave a warning for --pylab - are there any other arguments people were used to using on the notebook server and getting passed down to the kernel? |
|
I don't know of any that people are using on purpose. I do recall a couple of times it happened by accident and confused people. |
|
Executive decision from @fperez : We can kill this for 3.0, but let's special case |
|
Yep, agree that it should at least print a message that it does not work anymore. |
|
need rebase. |
this is deprecated in 2.0, and will be removed in 3.0
and remove the unused kernel flags
|
rebased |
| """ | ||
| ) | ||
| def _pylab_changed(self, name, old, new): | ||
| """when --pylab is specified, display a warning and ignore the value""" |
There was a problem hiding this comment.
Fernando reckoned (and I agree) that if --pylab is set, the server should actually refuse to start, because it's too easy to ignore the warning if it starts anyway.
There was a problem hiding this comment.
Yup, and since this is only a startup issue, the most it's likely to break is people's aliases and work habits (which we want them to update), not existing code beyond now needing %pylab atop notebooks that might implicitly rely on having been started via --pylab.
There was a problem hiding this comment.
Just for completeness, let's update the docstring to say it exits. Then I think this is ready for merge.
There was a problem hiding this comment.
Just for completeness, let's update the docstring to say it exits. Then I think this is ready for merge.
Yep, I agree...
disable specifying kernel args on the notebook command-line
|
Should we ping the list about that ? |
|
+1 On Sun, Apr 20, 2014 at 2:04 PM, Matthias Bussonnier <
Fernando Perez (@fperez_org; http://fperez.org) |
|
I took care of it. |
disable specifying kernel args on the notebook command-line
this is deprecated in 2.0, and will be removed in 3.0
ipython notebook --pylab=inlinewill never work again!