Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove redundant qtconsole doc page (was moved to jupyter/qtconsole repo) #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2015
Merged

Remove redundant qtconsole doc page (was moved to jupyter/qtconsole repo) #8722

merged 2 commits into from
Aug 12, 2015

Conversation

lebedov
Copy link
Contributor

@lebedov lebedov commented Aug 12, 2015

See this thread for the context.

@lebedov lebedov changed the title Remove no longer supported --matplotlib and --colors. Remove no longer supported --matplotlib and --colors from qtconsole docs Aug 12, 2015
@Carreau
Copy link
Member

Carreau commented Aug 12, 2015

Wait ... Why do we still have qtconsole docs in IPython dir ? the docs should have been moved here ?

o_O.

Regardless of that +1 on the change. I just want to check before that we don't have a duplicate file in 2 repos.

@takluyver
Copy link
Member

Oh yeah, I think that's an oversight. We should probably get rid of the Qt console docs in the IPython repo.

@lebedov
Copy link
Contributor Author

lebedov commented Aug 12, 2015

The qtconfig doc pages in the ipython/ipython and jupyter/qtconfig repos do seem mostly duplicated (although the latter does contain a brief mention of the --colors option that should be expunged and doesn't mention the %matplotlib inline magic).

@lebedov
Copy link
Contributor Author

lebedov commented Aug 12, 2015

Should I update the PR to remove the qtconsole page from the ipython/ipython docs altogether?

@takluyver
Copy link
Member

If it's mainly the same content, yes, please do make a PR to remove this copy. Thanks!

@lebedov lebedov changed the title Remove no longer supported --matplotlib and --colors from qtconsole docs Remove redundant qtconsole doc page (was moved to jupyter/qtconfig repo) Aug 12, 2015
@lebedov
Copy link
Contributor Author

lebedov commented Aug 12, 2015

PR updated.

@takluyver takluyver changed the title Remove redundant qtconsole doc page (was moved to jupyter/qtconfig repo) Remove redundant qtconsole doc page (was moved to jupyter/qtconsole repo) Aug 12, 2015
@takluyver
Copy link
Member

Thanks

takluyver added a commit that referenced this pull request Aug 12, 2015
@takluyver
Merge pull request #8722 from lebedov/remove_kernel_opts_from_qtconso…
f2d072e 
…le_docs

Remove redundant qtconsole doc page (was moved to jupyter/qtconsole repo)
@takluyver takluyver merged commit f2d072e into ipython:master Aug 12, 2015
@minrk minrk modified the milestone: 4.1 Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lebedov @Carreau @takluyver @minrk