[SPIRV][Codegen] Refine consumer compatibility checks for SPIRVSubgroupReduce#23176
Merged
Conversation
Signed-off-by: Eric Feng <[email protected]>
Signed-off-by: Eric Feng <[email protected]>
Signed-off-by: Eric Feng <[email protected]>
Signed-off-by: Eric Feng <[email protected]>
Signed-off-by: Eric Feng <[email protected]>
Signed-off-by: Eric Feng <[email protected]>
kuhar
approved these changes
Jan 17, 2026
Signed-off-by: Eric Feng <[email protected]>
Signed-off-by: Eric Feng <[email protected]>
keshavvinayak01
pushed a commit
that referenced
this pull request
Jan 27, 2026
…upReduce (#23176) Improves `SPIRVSubgroupReduce` kernel config selection for reductions with consumers. Refines consumer compatibility checks and improves workgroup size fallback by halving from the original group size down to `subgroup_size` to find a consumer compatible size, rather than clamping immediately. Also bail out of reduction pipeline entirely when consumers are fundamentally non-distributable under the constraints. Fixes: #23177 --------- Signed-off-by: Eric Feng <[email protected]> Signed-off-by: Keshav Vinayak Jha <[email protected]>
MaheshRavishankar
pushed a commit
to MaheshRavishankar/iree
that referenced
this pull request
Feb 24, 2026
…upReduce (iree-org#23176) Improves `SPIRVSubgroupReduce` kernel config selection for reductions with consumers. Refines consumer compatibility checks and improves workgroup size fallback by halving from the original group size down to `subgroup_size` to find a consumer compatible size, rather than clamping immediately. Also bail out of reduction pipeline entirely when consumers are fundamentally non-distributable under the constraints. Fixes: iree-org#23177 --------- Signed-off-by: Eric Feng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves
SPIRVSubgroupReducekernel config selection for reductions with consumers. Refines consumer compatibility checks and improves workgroup size fallback by halving from the original group size down tosubgroup_sizeto find a consumer compatible size, rather than clamping immediately. Also bail out of reduction pipeline entirely when consumers are fundamentally non-distributable under the constraints.Fixes: #23177