A couple of fixes picked up in the fusilli tests using sanitizers.#23617
Merged
Conversation
Signed-off-by: Andrew Woloszyn <[email protected]>
We were potentially memcpying 0 bytes from nullptr to a destination. Although this works just fine, it's a UBSan issue. Signed-off-by: Andrew Woloszyn <[email protected]>
There is a memory leak in RCCL meaning if we load and unload rccl repeatedly we will continue to leak memory. Signed-off-by: Andrew Woloszyn <[email protected]>
Contributor
Author
sjain-stanford
approved these changes
Mar 4, 2026
Member
sjain-stanford
left a comment
There was a problem hiding this comment.
I ran the fusilli *SAN build on your branch. It runs fine - just that I had to rebase your branch on latest main (since we fixed for the IREE device group changes). Everything else looks good with the suppressions (except RCCL one) removed. Stamping this.
This was
linked to
issues
Mar 4, 2026
kimm240
pushed a commit
to kimm240/iree
that referenced
this pull request
May 8, 2026
…ree-org#23617) This fixes some *SAN issues found in the fusilli tests. --------- Signed-off-by: Andrew Woloszyn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some *SAN issues found in the fusilli tests.