Connect transform dialect passes into IREE.#8602
Merged
Merged
Conversation
d8ab5d4 to
729f1b9
Compare
Contributor
Author
|
@benvanik could you please comment on at least the extra dependencies ? OTOH, in order to create a more contained unit test for this PR, I also had to do the same for the Bufferization dialect. The nested pass structure make the additional changes less than ideal but maybe there is a better / more automated way to achieve the same? |
729f1b9 to
3a86923
Compare
MaheshRavishankar
requested changes
Mar 23, 2022
Collaborator
MaheshRavishankar
left a comment
There was a problem hiding this comment.
Overall looks fine. Just a few questions about the dependent dialect specification.
3a86923 to
9898349
Compare
This commit adds a flag `-iree-codegen-use-sandbox-passes` that can be
used to transformations from sandbox within IREE in an e2e manner.
For now the pipeline just
- Sets the number of workgroups to {1, 1, 1} for sequential execution.
- Bufferizes the operations and lowers them to loops and LLVM IR.
This revision provides a first connection between IREE and the transform dialect by allowing the orthogonal specification of a linalg_transform file (policy) that is parsed and applied on the fly.
9898349 to
8c79173
Compare
MaheshRavishankar
approved these changes
Mar 23, 2022
| IREE::Flow::FlowDialect, | ||
| IREE::HAL::HALDialect, | ||
| IREE::LinalgExt::IREELinalgExtDialect, | ||
| mlir::linalg::transform::LinalgTransformDialect, |
Collaborator
There was a problem hiding this comment.
Ah, I know why this is here, but the namespace difference is a bit off-putting. Just noting, not making it blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision provides a first connection between IREE and the transform dialect by
allowing the orthogonal specification of a linalg_transform file (policy) that is
parsed and applied on the fly.