BCN - Lennie #294
Closed
BCN - Lennie #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawebbcn
reviewed
Mar 21, 2018
| if (num1>num2) { | ||
| return num1; | ||
| } else if (num2 > num1) { | ||
| return num2; |
There was a problem hiding this comment.
Is this moment, mean that num2 is greater or equal than num1 so we can just put return num2
| var total = [0]; | ||
| for (var j = 0; j < numbersAvg.length; j++) { | ||
| total += numbersAvg[j]; | ||
| } |
There was a problem hiding this comment.
You can reuse your sumArray
| } | ||
| if (total > 0) { | ||
| return total/numbersAvg.length; | ||
| } else if (total == 0) { |
| } | ||
| if (total > 0) { | ||
| return total/numbersAvg.length; | ||
| } else if (total == 0) { |
There was a problem hiding this comment.
You don't need this. If total > 0 return the average. Else don't do anything. Javascript will return undefined as default
| for (var k = 0; k < wordsArr.length; k++) { | ||
| allLetters += wordsArr[k].length; | ||
| } | ||
| if (allLetters == 0) { |
There was a problem hiding this comment.
You should check this in the beginning of the function and better with something like wordsArr.length > 0
| @@ -48,6 +103,15 @@ var wordsUnique = [ | |||
| 'bring' | |||
| ]; | |||
|
|
|||
| function uniquifyArray (wordsUnique) { | |||
| var wordsNoDuplicates = Array.from(new Set(wordsUnique)); | |||
There was a problem hiding this comment.
Set! 👍
But you know how a Set works? 👀
| var searchTerm = 'trouble'; | ||
|
|
||
| function doesWordExist (wordsFind, searchTerm) { | ||
| return (wordsFind.includes(searchTerm)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.