MIA-Crystal Meneses #326
Closed
MIA-Crystal Meneses #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for(var i = 0; i < words.length; i++) { | ||
| if(words[i].length > length) { | ||
| var length = words[i].length; | ||
| Longest = words[i]; |
There was a problem hiding this comment.
Don't capitalize a variable name. You capitalized "Longest".
| }; | ||
|
|
||
| function averageNumbers (numbers) { | ||
| var Average = 0; |
There was a problem hiding this comment.
Don't capitalize a variable name. You capitalized "Average".
| return total; | ||
| }; | ||
|
|
||
| function averageNumbers (numbers) { |
There was a problem hiding this comment.
Your "averageNumbers" function did not work for me when I tried it. Here is one approach you could have done:
// Calculate the Average
function averageNumbers(array) {
if (array.length === 0) {
return undefined;
}
console.log(sumArray(array), array.length);
return sumArray(array) / array.length;
}
var numbersAvg = [2, 6, 9, 10, 7, 4, 1, 9];
var average = averageNumbers(numbersAvg);
console.log(average);|
Try to apply this feedback on your next project. Kind Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.