This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Replace mimemagic with mini_mime#145
Merged
Merged
Conversation
Signed-off-by: Behrouz Soroushian <[email protected]>
irphilli
approved these changes
Apr 20, 2021
irphilli
left a comment
Owner
There was a problem hiding this comment.
Thanks for this! The mimemagic headache is enough to warrant the switch 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address: #144 and #143
Switch to
mini_mimesimilar to what Rails did: rails/rails@7c55e37Not really a necessary change now that
mimemagichas released new versions with MIT licenses 🤷 .