Improve modified files#263
Merged
Merged
Conversation
added 7 commits
April 21, 2023 09:54
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 15 15
Lines 1045 1048 +3
=======================================
+ Hits 1017 1020 +3
Misses 28 28
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that we ask for diffs, source code before and after the change, in a block. Which means, every time we ask for a diff, we also get source code before and after. Which is a waste of time and resources.
So I brought the computation of source code and diff to the modified file, and it's computed only when requested.