Fix nodiscard warning in meta.cpp #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I'm a member of the Microsoft vcpkg team, I am submitting this Pull Request to address the compilation warning triggered by the use of the
std::runtime_errorconstructor on line 26 oflibsrc/meta.cpp. This warning is issued by the MSVC compiler (C4834) due to the discarded return value of a function with the[[nodiscard]]attribute.It's important to note that this warning does not exist in the released versions of Visual Studio but was introduced after the recent STL PR (microsoft/STL#5174)). This change causes the compiler to issue a warning when the return value is discarded.
Specific Change:
throwkeyword to thestd::runtime_errorcall inmeta.cpp.This change resolves the warning and ensures compatibility with the latest STL implementation.
Thank you for reviewing this PR! If there are any other changes or improvements needed, please feel free to let me know.