Support Typescipt or Flow static types #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if we could just use #205 to provide this? I'm not too keen on the idea of having two options control plugins, it seems like it could become confusing. |
|
yeah, we can do it in the #205. regarding static types, it's important to know that plugin |
|
Now that I've merged #205 I'm not sure what you want to do with this? Maybe this could be solved by documenting the conflict? |
|
yes, mention it in the documentation is enough |
|
I think we should close this and have the doc PR separately. Thanks again for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
Better compatibility when is instrumenting the code. Project with Typescript code has a lot of issues when flow can't instrument the code.
staticTypewith default valueflow, it can beflowortypescript