15200 - Improve Script for Detecting Snips Requiring PR Tests #16839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #15200.
This PR refactors
scripts/pr_tests.py
to instead use the files changed portion of a PR to determine which snips require testing.Proof of Testing
@craigbox left some examples in #15200 of where problems were encountered. I used those as my testing for the updates to this script.
For folks that want to test, installing
uv
is straightforward and makes the dependency management of Python much easier. Installation instructions are here.Correctly found all snips requiring testing in a PR:
Correctly did not test snips being removed in a PR:
Reviewers