fix: fall back to AAAA lookup for socks5 hostnames with no A record - #2054
Open
immanuwell wants to merge 1 commit into
Open
fix: fall back to AAAA lookup for socks5 hostnames with no A record#2054immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: immanuwell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socks5 dns lookup only ever queries A records, never AAAA
dns_lookup()picks A vs AAAA based onclient_addr.is_ipv4().but
client_addris just the socks client's own tcp peer addr, and the socks5 listener only binds on127.0.0.1.so that check is always true. AAAA never gets queried
result: hostnames with only AAAA records fail to resolve, even when the resolver has a valid answer for them.
not new either, the PR that added this (#1096) straight up said "the DNS usage is wonky".
repro: added a test with a stub resolver that only answers AAAA. fails on master with
DnsEmpty:fix: try A first, same as before, fall back to AAAA if empty.
no behavior change for hosts that already work
tests, clippy and fmt all pass