Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: correct CIDR service entry mapping updates - #2086

Open
zac-nixon wants to merge 2 commits into
istio:masterfrom
zac-nixon:master
Open

fix: correct CIDR service entry mapping updates#2086
zac-nixon wants to merge 2 commits into
istio:masterfrom
zac-nixon:master

Conversation

@zac-nixon

Copy link
Copy Markdown

fixes: #2085

It's a small fix to remove the existing service entry, and replace it with the current service snapshot, which matches the other spots in the code which also need to do service updates

@zac-nixon
zac-nixon requested a review from a team as a code owner September 3, 2026 17:52
@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @zac-nixon! This is either your first contribution to the Istio ztunnel repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing

Copy link
Copy Markdown
Contributor

Hi @zac-nixon. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 3, 2026
@istio-testing

Copy link
Copy Markdown
Contributor

Hi @zac-nixon. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@keithmattix

Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 3, 2026
@zac-nixon

Copy link
Copy Markdown
Author

Hi @ilrudie can you take a look here! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service endpoints for CIDR look ups are left stale

5 participants