Conversation
Temurin no longer ships the jmods folder in the JDK (JEP 493), which jlink requires with --add-modules ALL-MODULE-PATH. Fix #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1.
Since JDK 24, Temurin no longer ships the
jmodsfolder in the JDK (JEP 493).jlink --add-modules ALL-MODULE-PATHthen fails with--module-path option must be specified.Changes
Contents/Home/jmods, download the JMODs archive for the same release and architecture from the Adoptium API into./<arch>/jmods. It is cached together with the JDK.jlinkis called with--module-path, using the bundled JMODs (before JDK 24) or the downloaded ones (JDK 24 and later). The resulting runtime still contains all modules.Testing
Not run yet. After merging, run the workflow with
jdk-25.0.3+9, which failed in run 28674987037. The workflow can also be dispatched against this branch first:JMODs archives exist for
jdk-25.0.3+9andjdk-25.0.4.1+1. The Adoptium API returns 404 forjdk-24.0.1+9.