Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dacbd
Copy link
Contributor

@dacbd dacbd commented Jul 11, 2022

Closes #75

@dacbd dacbd marked this pull request as ready for review July 12, 2022 15:45
@dacbd dacbd requested a review from a team July 12, 2022 15:46
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download

@0x2b3bfa0
Copy link
Member

@dacbd
Copy link
Contributor Author

dacbd commented Jul 12, 2022

download

hmm break because somehow a user has node12 or break because they are using dvc plots with v5 schema?

@dacbd dacbd merged commit 75c0129 into v1 Jul 12, 2022
@dacbd dacbd deleted the update-vega-lite branch July 12, 2022 20:46
@dacbd dacbd restored the update-vega-lite branch July 12, 2022 20:46
@0x2b3bfa0 0x2b3bfa0 deleted the update-vega-lite branch July 12, 2022 20:50
@0x2b3bfa0
Copy link
Member

Break because somehow a user has Node.js 12

☝🏼🦢⬛ Unlikely, but possible. Fault-induced telemetry will suffice: if there are no complaints, we're good. 😈

@dacbd
Copy link
Contributor Author

dacbd commented Jul 12, 2022

well, I tagged the previous commit as v1.1.4 and the squashed commit as v1.2.0 so there is an immediate fix if someone encounters an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Old vega version - causes conflict with certain plot ecodings

3 participants