Refactor deploy gtnh#4141
Open
SgtMate wants to merge 8 commits into
Open
Conversation
Owner
|
Glancing at the changes they look good. I just wanted to mention that the complexity in this script is why I started shifting over to mc-image-helper where I could implement these kinds of things in Java 😄 |
Contributor
Author
|
@itzg yes get it. I think I got to do the same in the long run, but this is the first step to bring the script in a more program like functional structure. I see it as a step towards moving complexity over there or enabling others to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve code quality and structure of the deployment script for GregTech New Horizon.
It also comes with a small ajustment of the wiki documentation.