Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1933 +/- ##
=======================================
Coverage 92.12% 92.12%
=======================================
Files 112 112
Lines 23067 23067
=======================================
Hits 21251 21251
Misses 1816 1816 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates auto-update output formatting by removing surrounding brackets from workspace project headers, and adjusts the corresponding integration test snapshot to match the new stdout.
Changes:
- Remove
[]around the printed project header (config file path) inauto-updatedisplay output. - Update the
auto_update_workspacesnapshot to expect the unbracketed header lines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/prek/src/cli/auto_update.rs | Changes project header rendering to print the config file path without brackets. |
| crates/prek/tests/auto_update.rs | Updates the workspace auto-update snapshot output to match the new header format. |
📦 Cargo Bloat ComparisonBinary size change: +0.00% (25.7 MiB → 25.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 1 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.1 ± 0.1 | 2.0 | 2.3 | 1.00 |
prek-head --version |
2.2 ± 0.1 | 2.1 | 3.0 | 1.05 ± 0.06 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
8.6 ± 0.1 | 8.4 | 9.1 | 1.00 |
prek-head list |
8.8 ± 0.8 | 8.5 | 16.6 | 1.02 ± 0.10 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
2.9 ± 0.1 | 2.8 | 3.1 | 1.00 |
prek-head validate-config .pre-commit-config.yaml |
2.9 ± 0.2 | 2.8 | 4.1 | 1.01 ± 0.08 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.7 ± 1.8 | 2.3 | 15.0 | 1.14 ± 0.76 |
prek-head sample-config |
2.4 ± 0.1 | 2.3 | 2.5 | 1.00 |
✅ Performance improvement for sample-config: 12.3200% faster
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
141.2 ± 3.2 | 136.1 | 145.6 | 1.01 ± 0.03 |
prek-head run --all-files |
140.5 ± 3.4 | 136.6 | 147.8 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
139.7 ± 4.0 | 134.3 | 149.0 | 1.00 |
prek-head run --all-files |
140.2 ± 3.8 | 133.3 | 146.6 | 1.00 ± 0.04 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
140.5 ± 4.5 | 133.8 | 160.8 | 1.00 ± 0.04 |
prek-head run --all-files |
140.5 ± 3.9 | 133.1 | 152.2 | 1.00 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
20.0 ± 0.6 | 19.2 | 21.3 | 1.00 |
prek-head run trailing-whitespace --all-files |
28.8 ± 31.0 | 19.2 | 169.7 | 1.44 ± 1.55 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
26.8 ± 2.7 | 22.7 | 33.6 | 1.00 |
prek-head run end-of-file-fixer --all-files |
26.8 ± 2.4 | 22.8 | 31.2 | 1.00 ± 0.14 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
11.5 ± 0.4 | 10.9 | 12.9 | 1.00 |
prek-head run check-json --all-files |
11.7 ± 0.4 | 11.0 | 12.5 | 1.02 ± 0.05 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
11.4 ± 0.1 | 11.0 | 11.6 | 1.00 |
prek-head run check-yaml --all-files |
11.5 ± 0.3 | 11.1 | 12.5 | 1.01 ± 0.03 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
11.3 ± 0.3 | 10.9 | 11.9 | 1.00 |
prek-head run check-toml --all-files |
11.5 ± 0.4 | 10.7 | 12.4 | 1.02 ± 0.05 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
11.2 ± 0.4 | 10.7 | 12.7 | 1.01 ± 0.05 |
prek-head run check-xml --all-files |
11.1 ± 0.4 | 10.5 | 12.5 | 1.00 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
17.6 ± 1.2 | 14.6 | 19.7 | 1.04 ± 0.10 |
prek-head run detect-private-key --all-files |
16.9 ± 1.1 | 15.0 | 19.4 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
21.6 ± 1.8 | 18.8 | 25.1 | 1.00 ± 0.11 |
prek-head run fix-byte-order-marker --all-files |
21.5 ± 1.7 | 19.1 | 24.8 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.4 ± 0.0 | 4.3 | 4.4 | 1.01 ± 0.02 |
prek-head install-hooks |
4.3 ± 0.1 | 4.2 | 4.4 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.4 ± 0.1 | 4.3 | 4.5 | 1.00 |
prek-head install-hooks |
4.5 ± 0.0 | 4.5 | 4.6 | 1.03 ± 0.02 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
48.3 ± 0.9 | 46.6 | 49.9 | 1.00 ± 0.03 |
prek-head run |
48.3 ± 0.8 | 46.6 | 49.6 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
8.5 ± 1.7 | 7.9 | 15.6 | 1.06 ± 0.21 |
prek-head run --files '*.json' |
8.0 ± 0.1 | 7.9 | 8.2 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
12.4 ± 0.3 | 12.1 | 13.4 | 1.00 |
prek-head run --dry-run --all-files |
12.4 ± 0.5 | 12.0 | 14.2 | 1.00 ± 0.04 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
12.6 ± 0.1 | 12.4 | 13.0 | 1.00 |
prek-head run check-hooks-apply --all-files |
12.8 ± 0.2 | 12.5 | 13.1 | 1.02 ± 0.02 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
11.5 ± 0.5 | 11.3 | 12.7 | 1.00 |
prek-head run check-useless-excludes --all-files |
11.7 ± 1.1 | 11.2 | 15.4 | 1.01 ± 0.10 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
9.7 ± 0.1 | 9.6 | 10.0 | 1.00 |
prek-head run identity --all-files |
9.8 ± 0.1 | 9.6 | 10.0 | 1.01 ± 0.02 |
No description provided.