Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2201 +/- ##
==========================================
+ Coverage 92.55% 92.57% +0.01%
==========================================
Files 123 124 +1
Lines 26347 26461 +114
==========================================
+ Hits 24386 24495 +109
- Misses 1961 1966 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f95757b11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📦 Cargo Bloat ComparisonBinary size change: +0.00% (26.5 MiB → 26.5 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 4 regressions, 6 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
1.9 ± 0.1 | 1.8 | 2.6 | 1.01 ± 0.07 |
prek-head --version |
1.9 ± 0.1 | 1.8 | 2.2 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
8.0 ± 1.3 | 7.2 | 14.3 | 1.01 ± 0.32 |
prek-head list |
7.9 ± 2.1 | 7.3 | 26.1 | 1.00 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
2.9 ± 1.5 | 2.6 | 13.3 | 1.06 ± 0.58 |
prek-head validate-config .pre-commit-config.yaml |
2.8 ± 0.5 | 2.6 | 6.5 | 1.00 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.5 ± 1.4 | 2.1 | 9.6 | 1.00 |
prek-head sample-config |
3.0 ± 3.4 | 2.1 | 18.8 | 1.18 ± 1.48 |
prek sample-config: 17.5800% slower
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
59.6 ± 1.9 | 56.9 | 62.9 | 1.01 ± 0.04 |
prek-head run --all-files |
58.8 ± 1.7 | 56.2 | 61.4 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
58.6 ± 2.7 | 55.8 | 65.8 | 1.00 |
prek-head run --all-files |
59.5 ± 2.6 | 55.5 | 64.1 | 1.02 ± 0.06 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
58.6 ± 2.7 | 54.8 | 66.1 | 1.00 |
prek-head run --all-files |
59.4 ± 2.5 | 54.9 | 64.0 | 1.01 ± 0.06 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
16.1 ± 0.3 | 15.7 | 16.7 | 1.00 |
prek-head run trailing-whitespace --all-files |
16.1 ± 0.5 | 15.5 | 17.5 | 1.00 ± 0.04 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
36.3 ± 49.1 | 18.6 | 232.7 | 1.63 ± 2.24 |
prek-head run end-of-file-fixer --all-files |
22.3 ± 5.0 | 19.2 | 47.1 | 1.00 |
✅ Performance improvement for prek run end-of-file-fixer --all-files: 38.6000% faster
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
6.5 ± 0.2 | 6.2 | 7.2 | 1.00 |
prek-head run check-json --all-files |
6.6 ± 0.5 | 6.0 | 8.7 | 1.01 ± 0.08 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
6.4 ± 0.2 | 6.2 | 7.3 | 1.02 ± 0.04 |
prek-head run check-yaml --all-files |
6.3 ± 0.1 | 6.1 | 6.6 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
7.5 ± 5.5 | 6.1 | 36.2 | 1.00 |
prek-head run check-toml --all-files |
14.5 ± 29.6 | 6.1 | 159.3 | 1.92 ± 4.16 |
prek run check-toml --all-files: 92.4200% slower
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
19.5 ± 37.3 | 6.3 | 173.3 | 1.13 ± 3.45 |
prek-head run check-xml --all-files |
17.3 ± 41.3 | 6.1 | 178.3 | 1.00 |
✅ Performance improvement for prek run check-xml --all-files: 11.1700% faster
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
11.6 ± 3.2 | 9.4 | 27.8 | 1.00 |
prek-head run detect-private-key --all-files |
17.4 ± 25.8 | 9.6 | 151.7 | 1.49 ± 2.25 |
prek run detect-private-key --all-files: 49.2400% slower
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
21.9 ± 21.4 | 13.9 | 104.5 | 1.40 ± 1.40 |
prek-head run fix-byte-order-marker --all-files |
15.7 ± 3.9 | 13.8 | 35.7 | 1.00 |
✅ Performance improvement for prek run fix-byte-order-marker --all-files: 28.3700% faster
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.9 ± 0.1 | 3.8 | 4.0 | 1.00 |
prek-head install-hooks |
3.9 ± 0.1 | 3.8 | 4.1 | 1.00 ± 0.03 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.8 ± 0.1 | 3.7 | 3.9 | 1.00 |
prek-head install-hooks |
3.9 ± 0.0 | 3.8 | 3.9 | 1.02 ± 0.03 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
31.3 ± 0.9 | 30.0 | 32.8 | 1.00 |
prek-head run |
33.3 ± 7.0 | 30.3 | 62.3 | 1.07 ± 0.23 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
6.8 ± 0.1 | 6.7 | 7.1 | 1.00 |
prek-head run --files '*.json' |
7.6 ± 3.3 | 6.7 | 21.6 | 1.11 ± 0.48 |
prek run --files '*.json' (specific file type): 11.0800% slower
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
10.2 ± 19.3 | 5.8 | 92.4 | 1.76 ± 3.33 |
prek-head run --dry-run --all-files |
5.8 ± 0.0 | 5.7 | 5.9 | 1.00 |
✅ Performance improvement for prek run --dry-run --all-files (measures init overhead): 43.3100% faster
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
91.4 ± 95.8 | 10.0 | 255.6 | 4.15 ± 6.95 |
prek-head run check-hooks-apply --all-files |
22.0 ± 28.8 | 8.8 | 90.2 | 1.00 |
✅ Performance improvement for prek run check-hooks-apply --all-files: 75.9000% faster
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
9.1 ± 0.2 | 8.8 | 9.6 | 1.00 |
prek-head run check-useless-excludes --all-files |
9.3 ± 0.3 | 9.1 | 10.1 | 1.02 ± 0.04 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
21.0 ± 25.9 | 8.4 | 77.0 | 1.41 ± 2.93 |
prek-head run identity --all-files |
14.9 ± 24.8 | 8.3 | 104.5 | 1.00 |
✅ Performance improvement for prek run identity --all-files: 29.1800% faster
There was a problem hiding this comment.
Pull request overview
This PR adds first-class perl language support to prek, moving Perl from “unimplemented” to a supported language backend alongside existing language runners.
Changes:
- Implement a new Perl language backend that installs hook repos via
cpaninto a per-hook environment and runs hooks with the appropriate environment variables. - Add integration tests covering local Perl hooks,
additional_dependencies,language_versionrejection, andshellexecution. - Update documentation and CI (language matrix + workflow environment) to reflect and validate Perl support.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/generate_ci_matrix.py | Adds perl to the CI language-test matrix generation. |
| docs/reference/configuration.md | Updates shell/language tables to no longer list Perl as unimplemented. |
| docs/proposals/hook-shell.md | Mirrors the configuration reference update for Perl support. |
| docs/languages.md | Documents Perl support, installation behavior, and language_version constraints. |
| crates/prek/tests/languages/perl.rs | New integration tests validating Perl hook install/run behaviors and errors. |
| crates/prek/tests/languages/main.rs | Registers the new Perl language test module. |
| crates/prek/src/languages/perl.rs | New Perl language implementation (install via cpan, run with env). |
| crates/prek/src/languages/mod.rs | Wires Language::Perl into supported/install/run dispatch and shell support. |
| crates/prek-consts/src/env_vars.rs | Adds Perl-related environment variable constants. |
| .github/workflows/ci.yml | Adds Perl presence checks and CI env settings for reliable CPAN usage during tests. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8da07e6453
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dba115951a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c98a0a17a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ( | ||
| // PERL5LIB makes Perl load modules installed into this hook env at runtime. | ||
| EnvVars::PERL5LIB, | ||
| env_path.join("lib").join("perl5").into_os_string(), | ||
| ), |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a581453af2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| NONINTERACTIVE_TESTING: ${{ contains(format(' {0} ', matrix.languages), ' perl ') && '1' || '' }} | ||
| # PERL_MM_USE_DEFAULT makes ExtUtils::MakeMaker answer any prompts | ||
| # with defaults, keeping CI noninteractive. | ||
| PERL_MM_USE_DEFAULT: ${{ contains(format(' {0} ', matrix.languages), ' perl ') && '1' || '' }} |
There was a problem hiding this comment.
Propagate Perl noninteractive env to Windows tests
The generated language matrix includes windows-latest with test(perl::), but these CPAN/MakeMaker noninteractive settings are only attached to the non-Windows run step. The Windows Run language tests (windows) step below runs the same Perl tests without them, so any CPAN distribution or first-time MakeMaker configuration prompt that this block is meant to suppress can still hang or fail that CI leg; set these at the job level or duplicate them in the Windows step.
Useful? React with 👍 / 👎.
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [prek](https://github.com/j178/prek) | patch | `0.4.4` → `0.4.5` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>j178/prek (prek)</summary> ### [`v0.4.5`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#045) [Compare Source](j178/prek@v0.4.4...v0.4.5) Released on 2026-06-15. ##### ✨Highlights 0.4.5 completes `prek`'s pre-commit language coverage. With R, Conda, Perl, and coursier now supported, `prek` supports every language available in pre-commit, plus `prek`-only modern languages such as Bun and Deno. This is full feature parity with pre-commit. The last major compatibility gap is closed, and `prek` is now on the path to 1.0. ##### 💚 Sponsorship If `prek` saves time for you or your team, please consider sponsoring the project on [GitHub Sponsors](https://github.com/sponsors/j178). It helps keep new features, performance work, and maintenance moving. ##### Enhancements - Add `Perl` language support ([#​2201](j178/prek#2201)) - Add `R` language support ([#​2206](j178/prek#2206)) - Add `Conda` language support ([#​2203](j178/prek#2203)) - Add `coursier` language support ([#​2194](j178/prek#2194)) - Add group filters to list ([#​2152](j178/prek#2152)) - Remove legacy repo path support ([#​2150](j178/prek#2150)) - Skip cloning fully filtered remote repos ([#​2151](j178/prek#2151)) ##### Performance - Avoid building JSON trees in syntax hooks ([#​2156](j178/prek#2156)) - Scan mixed line endings without line vector ([#​2160](j178/prek#2160)) - Skip file scan for always-run no-filename hooks ([#​2155](j178/prek#2155)) - Use fixed buffer for EOF scan ([#​2163](j178/prek#2163)) - Use fixed buffer for private key scan ([#​2164](j178/prek#2164)) ##### Bug fixes - Fix pretty-format-json CRLF handling ([#​2210](j178/prek#2210)) - Handle missing blobs in diff snapshots ([#​2211](j178/prek#2211)) - Ignore coursier channel from working repo ([#​2202](j178/prek#2202)) ##### Contributors - [@​j178](https://github.com/j178) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMTguMCIsInVwZGF0ZWRJblZlciI6IjQzLjIxOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
Closes #1447