Avoid allocating markdown extensions per file#2245
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
+ Coverage 92.63% 92.66% +0.03%
==========================================
Files 126 126
Lines 26900 26907 +7
==========================================
+ Hits 24918 24934 +16
+ Misses 1982 1973 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.00% (26.7 MiB → 26.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 1 regressions, 1 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.2 ± 0.1 | 2.0 | 2.5 | 1.03 ± 0.08 |
prek-head --version |
2.1 ± 0.1 | 2.0 | 2.9 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.0 ± 0.1 | 8.7 | 9.4 | 1.00 |
prek-head list |
9.1 ± 0.2 | 8.8 | 10.1 | 1.01 ± 0.03 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
3.0 ± 0.3 | 2.8 | 4.5 | 1.01 ± 0.10 |
prek-head validate-config .pre-commit-config.yaml |
3.0 ± 0.1 | 2.8 | 3.4 | 1.00 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.4 ± 0.0 | 2.3 | 2.5 | 1.00 |
prek-head sample-config |
2.4 ± 0.1 | 2.3 | 2.9 | 1.01 ± 0.04 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
76.4 ± 3.3 | 72.4 | 83.0 | 1.02 ± 0.06 |
prek-head run --all-files |
75.1 ± 2.8 | 71.2 | 79.7 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
75.4 ± 2.1 | 72.0 | 78.9 | 1.00 ± 0.05 |
prek-head run --all-files |
75.3 ± 2.7 | 71.4 | 81.6 | 1.00 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
75.6 ± 2.7 | 71.1 | 80.8 | 1.00 |
prek-head run --all-files |
75.7 ± 4.4 | 70.1 | 98.8 | 1.00 ± 0.07 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
19.8 ± 0.4 | 19.2 | 20.7 | 1.00 |
prek-head run trailing-whitespace --all-files |
19.8 ± 0.5 | 19.1 | 21.9 | 1.00 ± 0.03 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
26.0 ± 1.8 | 23.9 | 28.9 | 1.01 ± 0.11 |
prek-head run end-of-file-fixer --all-files |
25.8 ± 2.2 | 23.4 | 30.6 | 1.00 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
7.5 ± 0.3 | 7.1 | 8.0 | 1.00 |
prek-head run check-json --all-files |
7.5 ± 0.2 | 7.2 | 7.9 | 1.00 ± 0.04 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
7.4 ± 0.1 | 7.2 | 7.6 | 1.00 ± 0.02 |
prek-head run check-yaml --all-files |
7.4 ± 0.1 | 7.1 | 7.7 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
7.4 ± 0.3 | 7.0 | 8.2 | 1.02 ± 0.05 |
prek-head run check-toml --all-files |
7.3 ± 0.2 | 6.9 | 7.9 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
7.4 ± 0.2 | 7.0 | 7.9 | 1.00 |
prek-head run check-xml --all-files |
7.4 ± 0.2 | 7.0 | 8.1 | 1.01 ± 0.05 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
14.1 ± 1.2 | 12.0 | 16.7 | 1.05 ± 0.14 |
prek-head run detect-private-key --all-files |
13.4 ± 1.3 | 11.8 | 16.1 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
18.3 ± 0.8 | 17.1 | 19.7 | 1.00 ± 0.07 |
prek-head run fix-byte-order-marker --all-files |
18.3 ± 0.9 | 17.0 | 19.9 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.4 ± 0.0 | 4.3 | 4.4 | 1.00 ± 0.01 |
prek-head install-hooks |
4.4 ± 0.1 | 4.3 | 4.4 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.3 ± 0.0 | 4.2 | 4.3 | 1.00 |
prek-head install-hooks |
4.3 ± 0.0 | 4.2 | 4.3 | 1.01 ± 0.01 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
37.2 ± 1.6 | 35.3 | 41.8 | 1.01 ± 0.05 |
prek-head run |
37.0 ± 1.0 | 35.9 | 39.6 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
7.8 ± 0.1 | 7.7 | 8.0 | 1.00 |
prek-head run --files '*.json' |
25.4 ± 57.3 | 7.7 | 251.8 | 3.26 ± 7.37 |
prek run --files '*.json' (specific file type): 225.7800% slower
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
6.8 ± 0.5 | 6.5 | 8.9 | 1.00 ± 0.09 |
prek-head run --dry-run --all-files |
6.7 ± 0.4 | 6.6 | 8.2 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
11.6 ± 0.1 | 11.5 | 11.8 | 1.00 |
prek-head run check-hooks-apply --all-files |
11.7 ± 0.1 | 11.5 | 12.1 | 1.01 ± 0.01 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
11.8 ± 0.6 | 11.5 | 13.7 | 1.14 ± 0.05 |
prek-head run check-useless-excludes --all-files |
10.4 ± 0.1 | 10.2 | 10.5 | 1.00 |
✅ Performance improvement for prek run check-useless-excludes --all-files: 12.5900% faster
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
9.6 ± 0.1 | 9.4 | 9.8 | 1.00 ± 0.01 |
prek-head run identity --all-files |
9.6 ± 0.1 | 9.5 | 9.7 | 1.00 |
No description provided.