Allow mocking of DOMParser #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dee42
reviewed
Dec 10, 2020
dee42
reviewed
Dec 10, 2020
dist/plotly-with-meta.js
Outdated
| @@ -80745,7 +80745,7 @@ assign(ChineseCalendar.prototype, { | |||
| var month = this.toChineseMonth(year, monthIndex); | |||
|
|
|||
| var monthName = ['一月','二月','三月','四月','五月','六月', | |||
| '七月','八月','九月','十月','十一月','十二月'][month - 1]; | |||
| '七月','八月','九月','十月','十一月','十��月'][month - 1]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to mock
DOMParserby addingwindow.DOMParsersince these are synonyms anywas there is no harm in doing this but allows us to create a class. AFAIK we do not use DOMParser at this time, however we will mock it with another packagexmldomwhich we already use.Normally we would have had to upgrade
jsdomunfortunately that has code that requires babel plugins that are not available on v6. Upgrading babel is a whole-nother can-o-worms... As many of our packages are integrated with the version of babel.