Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implemented setters APIs#32

Merged
vjeux merged 14 commits into
jDataView:masterfrom
RReverser:master
Mar 13, 2013
Merged

Implemented setters APIs#32
vjeux merged 14 commits into
jDataView:masterfrom
RReverser:master

Conversation

@RReverser

Copy link
Copy Markdown
Member
  • Implemented setters(writers) for all the supported engines.
  • Simplified testing by using common functions in each module with testcases in argument.
  • Removed jQuery code for IE6-8 support from master branch (as not all the users really need it and those who do can easily use it from external source).

Please help me to update documentation (I added info on new methods but didn't touch examples nor changelog).

@vjeux

vjeux commented Mar 13, 2013

Copy link
Copy Markdown
Member

This is some seriously awesome stuff. Thanks a lot!

vjeux added a commit that referenced this pull request Mar 13, 2013
@vjeux vjeux merged commit 9de1c84 into jDataView:master Mar 13, 2013
@RReverser

Copy link
Copy Markdown
Member Author

You're welcome :) Will go and at last have some sleep before next step ;)

Btw, what about

*Please help me to update documentation (I added info on new methods but didn't touch examples nor changelog).
? Could you help?

@vjeux

vjeux commented Mar 13, 2013

Copy link
Copy Markdown
Member

Adding the changelog right now. I'll see what we can do about the examples.

Christopher "vjeux" Chedeau
Facebook Engineer
http://blog.vjeux.com/

On Wed, Mar 13, 2013 at 9:12 AM, Ingvar Stepanyan
[email protected]:

You're welcome :) Will go and at last have some sleep before next step ;)

Btw, what about

*Please help me to update documentation (I added info on new methods but
didn't touch examples nor changelog).

? Could you help?


Reply to this email directly or view it on GitHubhttps://github.com//pull/32#issuecomment-14850927
.

@RReverser

Copy link
Copy Markdown
Member Author

Ok, thanks a lot.
Then I'll definitely have a small break :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants