You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for checking. I didn't add any new keys, the change was purely deduplication. The file was rewritten with a small script so GitHub might show additions and deletion even though the actual set of first occurrence keys stayed the same. Happy to adjust though.
Thanks for checking. I didn't add any new keys, the change was purely deduplication. The file was rewritten with a small script so GitHub might show additions and deletion even though the actual set of first occurrence keys stayed the same. Happy to adjust though.
The diff shows only keys that have been moved around. The net diff is zero, which seems unexpected if you're deduplicating.
Hi @DeanLemans and @saberzero1, sorry for the confusion! I just realized what that meant. The previous script was misreading the file structure and flattened the Json. I'll work on a new update in a moment. Will also include the script code, just to be safe.
After double checking, I think there might not be actual real duplicates and the issue can be closed? There's one instance with "person walking facing right" that showed up 11 times, but they're actually different keys.
After double checking, I think there might not be actual real duplicates and the issue can be closed? There's one instance with "person walking facing right" that showed up 11 times, but they're actually different keys.
Yes. Different skin tones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2274
This PR removes duplicate keys in
quartz/util/emojimap.jsonthat were causing esbuild warnings during build.The duplicate entries included repeated emoji names such as:
The duplicates were removed using a small script, preserving the first occurrence of each key.
No functional changes were made.
Verification
npm run checkpassesnpx quartz build --serveruns without warnings