Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Include HTML in strDirectoryTypeWT #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ann0see merged 2 commits into from
Oct 28, 2022
Merged

Include HTML in strDirectoryTypeWT #2894

ann0see merged 2 commits into from
Oct 28, 2022

Conversation

@pljones
Copy link
Collaborator

@pljones pljones commented Oct 2, 2022 •
edited
Loading

Short description of changes

Update the "What's This?" text for the Directory Type drop down in the Server dialog to be a single string including the formatting HTML. This ensures translators have the full context when translating the string. Additionally, added an

CHANGELOG: Internal: Include HTML in strDirectoryTypeWT to make translation easier

Context: Fixes an issue?

See #2856 (comment)

Does this change need documentation? What needs to be documented and how?

No, needs translation changes.

Status of this Pull Request

Can wait till 3.10.0.

What is missing until this pull request can be merged?

Needs to be merge before translations can be done.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones mentioned this pull request Oct 2, 2022
Merged
@hoffie hoffie added this to the Release 3.10.0 milestone Oct 3, 2022
@hoffie
Copy link
Member

hoffie commented Oct 3, 2022

CHANGELOG: Include HTML in strDirectoryTypeWT to make translation easier

CHANGELOG: Internal: Include HTML in strDirectoryTypeWT to make translation easier

?

hoffie
hoffie approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good.
Translation-wise I don't think there is a good way. Either translators have to re-build the translation based on the existing fragments or we have to put effort into this to combine the fragments to a proposed ("unfinished") translation.

Usually, I'm more in favor of the latter, but in this case this sounds really error-prone, so I guess it's fine as-is.

Should be 3.10.0 though as it touches translations.

@pljones
Copy link
Collaborator Author

pljones commented Oct 3, 2022

Translation-wise I don't think there is a good way. Either translators have to re-build the translation based on the existing fragments or we have to put effort into this to combine the fragments to a proposed ("unfinished") translation.

Usually, I'm more in favor of the latter, but in this case this sounds really error-prone, so I guess it's fine as-is.

Yes... I did try moving the strings by hand and cleaning up the "vanished" ones -- but I decided it would take longer than just retranslating. Particularly as the first one hadn't been fully translated anyway, making it even harder.

@pljones pljones force-pushed the patch/include-html-in-translation-string branch 3 times, most recently from 43fa30d to d762a2f Compare October 13, 2022 21:16
@pljones pljones force-pushed the patch/include-html-in-translation-string branch from d762a2f to a88297a Compare October 17, 2022 20:48
@ann0see
Copy link
Member

ann0see commented Oct 19, 2022

@pljones this needs a rebase.

@pljones pljones force-pushed the patch/include-html-in-translation-string branch 4 times, most recently from 0b650ac to 73bcb31 Compare October 20, 2022 21:23
@pljones pljones force-pushed the patch/include-html-in-translation-string branch from 73bcb31 to a683fe7 Compare October 21, 2022 17:13
@ann0see ann0see merged commit 6a8875c into jamulussoftware:master Oct 28, 2022
@pljones pljones self-assigned this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoffie hoffie hoffie approved these changes

@ann0see ann0see ann0see approved these changes

Assignees

@pljones pljones

Labels

None yet

Projects

Tracking
Status: Done

Milestone

Release 3.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pljones @hoffie @ann0see