Add GPL header to autobuild scripts #3077
Conversation
|
This would also need to be added to the copyright notices update script... |
|
It might be worth updating the style guide to state any new code contribution should have the appropriate licence stated at the start of its body text, either under this PR or separately. |
0df5c2d to
0b49e44
Compare
|
I've now updated and rebased the files. I think the tools/ directory also needs licensing. |
Worth raising a 3.11.0 issue for that, I guess. |
|
I believe that's still covered in my linked issue. Maybe also in scope of this PR |
ann0see
left a comment
There was a problem hiding this comment.
Ah. Still needs an update in the tools/update-copyright-notices.sh file
8329fc6 to
94f9719
Compare
|
@pljones I've now added the notes to the tools directory too and updated the copyright updating script. I've tested .pl, .py and .sh files and all get updated correctly. |
CONTRIBUTING.md
Outdated
|
|
||
| ### Licensing | ||
|
|
||
| If you add new (source code) files, please add a header with the license to the file. This clarifies how your work is licensed. |
There was a problem hiding this comment.
We should say what the header MUST include:
- Legal copyright line
- Author(s) list
- Declaration of licence, indicating how to refer to the full text if not provided in full
Someone who knows more about this should confirm the above but I think that's why we have what we have.
This also adds a comment to the CONTRIBUTING guidelines Co-authored-by: pljones <[email protected]>
c0fc403 to
c9ddad0
Compare
|
@pljones please merge if you feel it's ok. |
Short description of changes
Adds GPL header to Autobuild scripts
CHANGELOG: Internal: Clarify licensing terms for Autobuild scripts
Context: Fixes an issue?
Fixes: #3026
Does this change need documentation? What needs to be documented and how?
I don't think so.
Status of this Pull Request
Ready for review - and discussion. I'd like to hear @hoffie here.
What is missing until this pull request can be merged?
Test by CI
Checklist
AUTOBUILD: Please build all targets