Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Autobuild: Update macOS SDK #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ann0see merged 1 commit into from
Jul 30, 2023
Merged

Autobuild: Update macOS SDK #3106

ann0see merged 1 commit into from
Jul 30, 2023

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Jul 19, 2023 •
edited
Loading

Short description of changes
Updates macOS build to all use Xcode 14.2 (macOS 13.1 SDK). Also updates some comments.

CHANGELOG: Build: macOS now uses the 13.1 SDK for better compatibility with modern macOS versions.

Context: Fixes an issue?

No

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Needs testing on modern macOS. Will do in the coming days.

What is missing until this pull request can be merged?

Quick test.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to the Release 3.10.0 milestone Jul 19, 2023
@ann0see ann0see force-pushed the updateMacOSSdk branch 3 times, most recently from 072d382 to 131e19b Compare July 19, 2023 20:52
@ann0see ann0see changed the title Autobuild: Update macOS and iOS SDK. Autobuild: Update macOS SDK Jul 19, 2023
@ann0see
Copy link
Member Author

ann0see commented Jul 19, 2023

iOS isn't upgradable.

@pljones
Copy link
Collaborator

pljones commented Jul 20, 2023

I can't check the macOS builds or comment on the workflow, unfortunately.

@ann0see
Copy link
Member Author

ann0see commented Jul 20, 2023

macOS Ventura 13.4 Client and Server open correctly. Listening works ok. Speaking doesn't work unless I start the app from terminal as it doesn't ask for recording permissions. This might be a bug on my machine only.

@gilgongo could you please test if this also happens to you?

@gilgongo
Copy link
Member

gilgongo commented Jul 25, 2023

I'm on Ventura 13.4.1 (c) - seems to work OK for me (no permissions problem at least, and I can hear and I think transmit OK but I didn't do complete test of that). Settings and connect windows came up in the background for some reason - I had to manually foreground them.

@pljones
Copy link
Collaborator

pljones commented Jul 25, 2023

Settings and connect windows came up in the background for some reason - I had to manually foreground them.

Almost certainly more Qt6 issues...

@ann0see
Copy link
Member Author

ann0see commented Jul 25, 2023

Hmm ok. So the SDK update is probably valid. But what should we do about the buggy Qt?

@ann0see
Autobuild: Update macOS SDK
d47d19c 
Use Xcode 14.2 macOS standard build
@ann0see
Copy link
Member Author

ann0see commented Jul 29, 2023

I think we should be able to upgrade the SDK then.

@ann0see ann0see requested review from gilgongo and pljones July 29, 2023 18:00
@ann0see ann0see mentioned this pull request Jul 29, 2023
Closed
57 tasks
@ann0see ann0see merged commit 3a2ae3d into jamulussoftware:main Jul 30, 2023
@ann0see ann0see deleted the updateMacOSSdk branch July 30, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones approved these changes

@gilgongo gilgongo Awaiting requested review from gilgongo

Assignees

@ann0see ann0see

Labels

None yet

Projects

Tracking
Status: Done

Milestone

Release 3.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ann0see @pljones @gilgongo