Build: Bump actions/checkout from 3 to 4 #3168
Conversation
|
We might need to update Linux builds soon too... |
|
Adding to 3.11.0 |
|
I don't seem to be able to rerun the fails. |
|
@dependabot rebase |
|
Maybe that kicks them again |
49f5a43 to
39eb6ec
Compare
|
We'll probably need to update node js somehow. |
Maybe upgrading ubuntu to LTS 20.04? |
|
I believe it led to the pan pots not showing up on Debian/Ubuntu. |
|
I build on LTS 22.04 locally - with Qt 5.15.3. I don't see any problems. With Qt6... well, keep well clear still. |
|
I'm unsure how to proceed, as we might have strange sideeffects on older versions of Ubuntu - and we can't test them all. I think the artifacts are built using a lower Qt version |
|
We need to get off 18.04 anyway - it's out of support. |
|
Hmm. Ok. I believe it's the same problem as we had with dropping Windows 7/8.1. Probably best to open a discussion. But if it's out of support, we should probably drop it |
|
@dependabot rebase |
39eb6ec to
eda3a3f
Compare
|
This doesn't run on the Docker container for Ubuntu-18.04. Updating |
There were a few other changes required, which I have as separate commits on https://github.com/softins/jamulus/tree/test-ubuntu
With the above changes, the build is green for all targets. See https://github.com/softins/jamulus/actions/runs/7843432263 |
|
@softins thanks! If I find some time, I'll have a look at this (hopefully). |
|
This PR will be safe to apply after #3229 has been approved and merged. |
|
@dependabot rebase |
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
eda3a3f to
d911b0e
Compare
softins
left a comment
There was a problem hiding this comment.
Builds succeeded - approving.
Bumps actions/checkout from 3 to 4.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
3df4ab1Release 4.0.0 (#1447)8b5e8b7Support fetching without the --progress option (#1067)97a652bUpdate default runtime to node20 (#1436)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)