-
Notifications
You must be signed in to change notification settings - Fork 238
Update Mac Legacy from Qt 5.9.9 to 5.15.2 #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9d28a8f to
cdd6697
Compare
86acc45 to
dfbfd75
Compare
dfbfd75 to
9258ad2
Compare
|
Reverted to using Qt 5.15.2, as per #3234 (comment) |
9258ad2 to
96abf40
Compare
|
I would like to progress this now, because I plan to submit a working PR to replace #2393, and that will be dependent on this one having been merged. |
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know that I have mixed feelings about this but you can argue that people on those devices should have upgraded years ago.
Going to approve it. But yes, this needs to be explained in the release notes.
|
We no longer officially link legacy directly on the website anyway as we didn't test it for the last release. So people know it's encouraged not to use it. |
pljones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because it builds clean. I've no way to test it.
|
Great, I'll do a final smoke test of the artifact and then merge. |
Short description of changes
Updates the CI build process and makefiles for Mac Legacy to use Qt 5.15.2 instead of 5.9.9. This allows other things also to be improved separately, as described in #3234
CHANGELOG: Build: Update Mac Legacy build to use Qt 5.15.2, now compatible with MacOS 10.13 (High Sierra) or newer.
Context: Fixes an issue?
Fixes #3234
Does this change need documentation? What needs to be documented and how?
We would need to document in the release notes and any download page that the minimum supported version of MacOS for the Legacy build would be 10.13 (High Sierra)
Status of this Pull Request
Working, but awaiting agreement on using Qt 5.15.2.
What is missing until this pull request can be merged?
Just agreement on using Qt 5.15.2
Checklist