Build: Only checkout submodules for android #3289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the Android build makes use of the submodule for oboe, so no need to fetch it when building other architectures.
5 tasks
pljones
approved these changes
Jun 11, 2024
ann0see
approved these changes
Jun 11, 2024
Member
ann0see
left a comment
There was a problem hiding this comment.
Looks sensible. The build would not succeed if they aren't checked out?
Member
Author
That's correct, because each CI build starts with a clean instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Only the Android build makes use of the submodule for oboe, so no need to fetch it when building other architectures.
CHANGELOG: Build: checkout of submodules only needed for Android
Context: Fixes an issue?
This just avoids unnecessary work in the CI when building targets other than Android.
Does this change need documentation? What needs to be documented and how?
I wouldn't have thought so.
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Nothing
Checklist