Fixes 3287: Only deregister on quit #3302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good to me. Just tested the Mac legacy artifact, and the server no longer deregisters when losing focus. @pljones thanks for the fast fix! |
softins
approved these changes
Jun 29, 2024
Collaborator
Author
|
OK, merged. @ann0see thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Fix for #3287
CHANGELOG: Server: Only de-register on quit
Context: Fixes an issue?
Fixes #3287
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Tested on Linux
What is missing until this pull request can be merged?
Check it fixes the original MacOS issue.
Checklist