Alternative workaround for ruff (astral-sh/ruff/#10299)#154
Closed
abravalheri wants to merge 1 commit into
Closed
Conversation
Closed
Owner
|
See #119 as to why I don't want to maintain this setting in multiple places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in pypa/setuptools#4718 (comment) and astral-sh/ruff#10299 (comment), including
pyproject.tomlinruff.tomldoes not look like a good workaround for astral-sh/ruff#10299, since it preventsrufffrom detecting and updating version related code branches.This PR implements @Avasam proposal for a temporary workaround. Hopefully
ruff's team can address the issue before we need to bump the min version of Python to 3.10.Alternative to #153. Closes #152.