Escape DEBUG directive in LoginStepDefinitions (Fixes #1373) #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1373) This PR fixes Issue jasontaylordev#1373 by wrapping the #if DEBUG block in LoginStepDefinitions.cs with //-:cnd:noEmit and //+:cnd:noEmit to prevent the .NET templating engine from removing it when generating new projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #1373 by wrapping the Debug-only Playwright launch options
in LoginStepDefinitions.cs with templating ignore comments (
//-:cnd:noEmitand
//+:cnd:noEmit) so they are preserved when generating a new solutionfrom the template.
The change ensures that the
#if DEBUGblock remains in generated projects,allowing developers to see Playwright run in headful mode during debugging.