This repository was archived by the owner on Oct 6, 2023. It is now read-only.
Borrowed Data #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let us not waste a ton of cpu time and memory cloning already utf8 fields into another memory location just because it is easier to write. But seriously, wow serde makes this difficult. TODO: Write tests to ensure that data is being deserialized correctly as I have some doubts.
Trying to convert all the Vec<T> to Box<[T]> as the deserialized (or serialized) data doesn't need mutability for appending/removing collection items. That is for the -live- data prior to entering into or being removed from the serialized form.
Got a nice little test macro up and running.
I cant do all the insane shit I want too, but oh well life goes on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are interested I converted the crate the work with the borrowed format of data.
Mostly done for my own purposes, but if you wanted to incorporate it I figured I would submit against the upstream.