Strings #133
Merged
Strings #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
deivuss331
requested changes
Oct 15, 2022
| assert.strictEqual(ucFirst("john"), "John"); | ||
| }); | ||
|
|
||
| it("Doesn't die on an empty string", function() { | ||
| it("Nie wysypuje się na na pustym łańcuchu", function() { |
|
Please make the requested changes. After it, add a comment "/done". |
|
/done |
deivuss331
approved these changes
Oct 15, 2022
|
@RafalMichniuk całkiem sprawnie wrzuciłeś poprawkę 😄 IMO jest ok, jak chcesz to zrób merge chyba że jeszcze ktoś doda review (ale chyba mało kto jest tu aktywny) |
|
@deivuss331 dzięki! 😎 OK, poczekam tydzień (to chyba nie dużo czasu w kontekście jak tu wszystko zasuwa 😅) i jak nie pojawi się żadne review, to zrobię merge 🙂 |
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translated article about Strings