Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ability to return default value on get but breaking get's API #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Add ability to return default value on get but breaking get's API #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bmemcached/client/distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,13 @@ def replace(self, key, value, time=0, compress_level=-1):
server = self._get_server(key)
return server.replace(key, value, time, compress_level)

def get(self, key, get_cas=False):
def get(self, key, default=None, get_cas=False):
"""
Get a key from server.

:param key: Key's name
:type key: six.string_types
:param default: In case memcached does not find a key, return a default value
:param get_cas: If true, return (value, cas), where cas is the new CAS value.
:type get_cas: boolean
:return: Returns a key data from server.
Expand All @@ -144,6 +145,11 @@ def get(self, key, get_cas=False):
return value, cas
return value

if default is not None:
if get_cas:
return default, None
return default

if get_cas:
return None, None

Expand Down
2 changes: 1 addition & 1 deletion bmemcached/client/mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def disconnect_all(self):
for server in self.servers:
server.disconnect()

def get(self, key, get_cas=False):
def get(self, key, default=None, get_cas=False):
raise NotImplementedError()

def gets(self, key):
Expand Down
7 changes: 6 additions & 1 deletion bmemcached/client/replicating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,13 @@ def enable_retry_delay(self, enable):
# add exponential falloff in the future. _set_retry_delay is exposed for tests.
self._set_retry_delay(5 if enable else 0)

def get(self, key, get_cas=False):
def get(self, key, default=None, get_cas=False):
"""
Get a key from server.

:param key: Key's name
:type key: six.string_types
:param default: In case memcached does not find a key, return a default value
:param get_cas: If true, return (value, cas), where cas is the new CAS value.
:type get_cas: boolean
:return: Returns a key data from server.
Expand All @@ -45,6 +46,10 @@ def get(self, key, get_cas=False):
return value, cas
else:
return value
if default is not None:
if get_cas:
return default, None
return default
if get_cas:
return None, None

Expand Down
4 changes: 4 additions & 0 deletions test/test_simple_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ def testGetSimple(self):
self.client.set('test_key', 'test')
self.assertEqual('test', self.client.get('test_key'))

def testGetDefault(self):
self.assertEqual(None, self.client.get('test_key'))
self.assertEqual('default_value', self.client.get('test_key', 'default_value'))

def testGetBytes(self):
# Ensure the code is 8-bit clean.
value = b'\x01z\x7f\x00\x80\xfe\xff\x00'
Expand Down