Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Return pickle as default serializer #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Return pickle as default serializer #73

merged 2 commits into from
Jan 13, 2017

Conversation

jaysonsantos
Copy link
Owner

@jaysonsantos jaysonsantos commented Jan 12, 2017

This change is Reviewable

@jaysonsantos
Copy link
Owner Author

This fixes #73

@jaysonsantos
Copy link
Owner Author

Hi @zzzeek would you mind taking a look on the api? I also tested dogpile tests + the ones of concurrency and everything seems to be working.

@zzzeek
Copy link

zzzeek commented Jan 12, 2017

OK, you uncommented the ones that were failing a long time ago? that's great. if you release this I can look into re-enabling those tests on my end.

@jaysonsantos
Copy link
Owner Author

@zzzeek Yes, I removed all the skips and they seem to be working

@jaysonsantos jaysonsantos merged commit 422a32a into master Jan 13, 2017
@jaysonsantos jaysonsantos deleted the return-pickle branch January 13, 2017 14:20
@jaysonsantos
Copy link
Owner Author

@zzzeek this should be working now

@zzzeek
Copy link

zzzeek commented Jan 13, 2017

confirmed this repairs normal test coverage, thanks very much! testing out the previously skipped tests as a separate change.

@zzzeek
Copy link

zzzeek commented Jan 13, 2017

still seeing a failure for the "concurrency" tests: https://jenkins.sqlalchemy.org/job/dogpile_gerrit/59/backend=memcached,pyv=py36/testReport/junit/tests.cache.test_memcached_backend/BMemcachedDistributedWithTimeoutTest/test_threaded_dogpile/ . These tests are quite crazy so aren't that great to figure out what might be going on, unfortunately.

@jaysonsantos
Copy link
Owner Author

strange, they worked on a clean docker environment. I will make some changes and try to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants