Fix deploy warning #531
Merged
Fix deploy warning #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 28 28
Lines 2652 2652
=======================================
Hits 2412 2412
Misses 240 240 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
claudep
approved these changes
Dec 10, 2022
Contributor
claudep
left a comment
There was a problem hiding this comment.
Fully trusting you on this matter 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deploy workflow shows this warning:
https://github.com/jazzband/tablib/actions/runs/3664520628
So let's use v1.
Also we can make the
github.repository == 'jazzband/tablib'check more generic asgithub.repository_owner == 'jazzband', so we can have fewer changes between Jazzband repos.And similarly, use Python version
3.xfor the latest available, instead of pinning to a specific.