fix bug when checking empty file. add more coverage #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 90.97% 91.16% +0.18%
==========================================
Files 28 28
Lines 2660 2670 +10
==========================================
+ Hits 2420 2434 +14
+ Misses 240 236 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Maybe just adapt the commit message to specify this concerns the yaml format. |
hugovk
requested changes
Jan 21, 2023
Member
hugovk
left a comment
There was a problem hiding this comment.
Please could you check the permissions failure on Windows?
Contributor
|
Ah yes, NamedTemporaryFile constructor is already returning a file-like object, so no need to reopen later (and Windows cannot reopen when it's already open). |
281fea9 to
4a17e3f
Compare
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding some coverage discovered the using
len(pickle)will raise and error since for empty filespickleisNone.Change the if condition to just
not picklesince it will also work for checking if the list is empty.Added two test cases to cover more branches.