Fix linting issues raised by flake8 #536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 91.16% 91.13% -0.03%
==========================================
Files 28 28
Lines 2670 2674 +4
==========================================
+ Hits 2434 2437 +3
- Misses 236 237 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
claudep
left a comment
There was a problem hiding this comment.
Minor things, but looks generally good, thanks!
| # Act / Assert | ||
| with self.assertRaises(NotImplementedError): | ||
| output = utils.getDateTime(value) | ||
| _ = utils.getDateTime(value) |
There was a problem hiding this comment.
Do we even need the attribution here?
src/tablib/packages/dbfpy/record.py
Outdated
| # for (_def, _dat) in zip(self.dbf.header.fields, self.fieldData): | ||
| # | ||
|
|
||
| # for (_def, _dat) in zip(self.dbf.header.fields, self.fieldData): |
There was a problem hiding this comment.
Do we even need this commented out code?
There was a problem hiding this comment.
There are some other commented codes that are old
Can all of them be deleted?
There was a problem hiding this comment.
Note that dbfpy is vendored code, we should make only minimal changes.
There was a problem hiding this comment.
There are some one-line commented codes like this:
tablib/src/tablib/packages/dbfpy/fields.py
Line 357 in b2be12e
What should I do about them?
e28930a to
f2b65c9
Compare
I ran flake8 and fixed all issues raised by it.
In my next PR, I will add flake8 to pre-commit (I can't send that PR before this because pre-commit runs by tox and breaks CI)
The change in
isortversion is because of a bug that fixed in the latest release. link - issue link