Allow importing 'ragged' .xlsx files through dataset #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good catch! I wonder if it would be worth factorizing that sheet import loop between both methods so such mistakes are less probable in the future? What do you think? |
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
=======================================
Coverage 91.39% 91.40%
=======================================
Files 28 28
Lines 2720 2723 +3
=======================================
+ Hits 2486 2489 +3
Misses 234 234
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Agreed ! I propose a new function |
Contributor
|
@hugovk I'm not sure that if I "Rebase and merge", the commit message change you suggested will be taken into account. May I let you do the merge? |
Member
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #465.
This is an almost blind copy paste of the work done by @claudep in #466 to allow importing ragged file through dataset also.
(#465 (comment))