Fixes #243 - Support import_set for html input #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 91.37% 91.59% +0.22%
==========================================
Files 28 28
Lines 2713 2785 +72
==========================================
+ Hits 2479 2551 +72
Misses 234 234
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Jul 2, 2023
hugovk
reviewed
Jul 3, 2023
| parser.feed(in_stream.read()) | ||
| if not parser.table_found: | ||
| if table_id: | ||
| raise ValueError(f'No <table> found with id="{table_id}" in input HTML') |
Member
There was a problem hiding this comment.
Shall we add a simple test to cover this line and check it executes as expected?
Contributor
Author
There was a problem hiding this comment.
Good suggestion, updated.
hugovk
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.