feat: ods: add style to datetime, date and time values #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 92.66% 92.68% +0.01%
==========================================
Files 28 28
Lines 2958 2966 +8
==========================================
+ Hits 2741 2749 +8
Misses 217 217 ☔ View full report in Codecov by Sentry. |
Contributor
|
Would you be able to add some test for that change? I find the commit message a bit misleading, as this is fixing ods export functionality, not ods reading. |
Contributor
Author
|
I changed the title and added tests. The tests currently fail, because the datetime export has a bug that was previously covered by the import: #595 |
Contributor
|
Please rebase after merge of #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #210 but for the ods format.
Let me know if you agree with this approach in general. I will then apply the same for datetime and time types.
Code is inspired by https://stackoverflow.com/a/28577394
I tested it with LibreOffice 7.3 so far.